Skip to content

Fix various file reminders bugs #39876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 3 commits into from
Aug 15, 2023
Merged

Fix various file reminders bugs #39876

Pytal merged 3 commits into from
Aug 15, 2023

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Aug 15, 2023 •
edited by AndyScherzinger
Loading

Summary

  • Allow non-admin users to access the API #ionlydevasadmin
  • Always output valid json e.g. files:reminders --output json, files:reminders --output json_pretty
  • Correctly delete reminders when node is deleted

Checklist

@Pytal Pytal added this to the Nextcloud 28 milestone Aug 15, 2023
@Pytal Pytal self-assigned this Aug 15, 2023
@Pytal
Copy link
Member Author

Pytal commented Aug 15, 2023

/backport to stable27

@Pytal Pytal requested a review from AndyScherzinger August 15, 2023 01:27
@jospoortvliet

This comment was marked as off-topic.

Sign in to view
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 15, 2023
@Pytal Pytal merged commit 3c13efd into master Aug 15, 2023
@Pytal Pytal deleted the fix/files-reminders branch August 15, 2023 15:40
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@Altahrim Altahrim Awaiting requested review from Altahrim

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: files

Projects

📁 Files team
Archived in project

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@Pytal @jospoortvliet @ArtificialOwl @AndyScherzinger