Refactor files_trashbin app commands #39882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $query->delete('files_trash') | ||
| ->where($query->expr()->eq('user', $query->createParameter('uid'))) | ||
| ->setParameter('uid', $uid); | ||
| $query->execute(); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| $userObject = $this->userManager->get($user); | ||
| $this->expireTrashForUser($userObject); | ||
| } else { | ||
| if (! $this->userManager->userExists($user)) { |
Check notice
Code scanning / Psalm
PossiblyNullReference
|
|
||
| $output->writeln("Remove deleted files of <info>$user</info>"); | ||
| $userObject = $this->userManager->get($user); | ||
| $this->expireTrashForUser($userObject); |
Check notice
Code scanning / Psalm
PossiblyNullArgument
|
|
||
| $p = new ProgressBar($output); | ||
| $p->start(); | ||
| $this->userManager->callForSeenUsers(function (IUser $user) use ($p) { |
Check notice
Code scanning / Psalm
PossiblyNullReference
fsamapoor
requested review from
a team,
blizzz,
icewind1991 and
nfebe
and removed request for
a team
fsamapoor
force-pushed
the
refactor_files_trashbin_app_commands
branch
from
42794ad to
35b0f7a
Compare
Member
Author
|
Conflicts resolved! |
Merged
fsamapoor
force-pushed
the
refactor_files_trashbin_app_commands
branch
from
35b0f7a to
e5e9aed
Compare
AndyScherzinger
force-pushed
the
refactor_files_trashbin_app_commands
branch
from
e5e9aed to
e085779
Compare
| } | ||
|
|
||
| return 0; | ||
| $this->config->setAppValue('files_trashbin', 'trashbin_size', (string)$parsedSize); |
Check notice
Code scanning / Psalm
DeprecatedMethod
added 2 commits
March 8, 2024 19:19
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
fsamapoor
force-pushed
the
refactor_files_trashbin_app_commands
branch
from
e085779 to
754b425
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have made some adjustments to the
apps/files_trashbin/lib/Commandclasses to improve the code readability.The improvements in this PR include but are not limited to:
Checklist