Skip to content

Refactor files trashbin app #39883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danialRahimy wants to merge 14 commits into from
Closed

Refactor files trashbin app #39883

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
558c146
Files trashbin app: Return early in method retainVersions
danialRahimy Aug 14, 2023
81c4780
Files trashbin app: Change the const name for more readability
danialRahimy Aug 14, 2023
2c298c0
Files trashbin app: Adding functions' return type
danialRahimy Aug 14, 2023
36338e8
Files trashbin app: Return early
danialRahimy Aug 15, 2023
dfceb76
Files trashbin app: Remove extra spaces between methods
danialRahimy Aug 15, 2023
a531255
Files trashbin app: Update doc types
danialRahimy Aug 15, 2023
82dd6fa
Files trashbin app: Add remaining return type.
danialRahimy Aug 15, 2023
8bd6a2f
Files trashbin app: Add parameter type to the methods according to th…
danialRahimy Aug 15, 2023
dcfcce8
Files trashbin app: Remove unrelated throw tag for clarification exc…
danialRahimy Aug 16, 2023
e1fa130
Update apps/files_trashbin/lib/Trashbin.php
danialRahimy Aug 20, 2023
b55f595
Update apps/files_trashbin/lib/Trashbin.php
danialRahimy Aug 20, 2023
863dd39
Update apps/files_trashbin/lib/Trashbin.php
danialRahimy Aug 20, 2023
a766334
Update apps/files_trashbin/lib/Trashbin.php
danialRahimy Aug 20, 2023
2186f0d
Update apps/files_trashbin/lib/Trashbin.php
danialRahimy Aug 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update apps/files_trashbin/lib/Trashbin.php 
Co-authored-by: F. E Noel Nfebe <[email protected]>
Signed-off-by: danial rahimy <[email protected]>
  • Loading branch information
@danialRahimy @nfebe
danialRahimy and nfebe authored Aug 20, 2023
commit b55f595b131c49daeb927807451ed4e33c96c70f
2 changes: 1 addition & 1 deletion apps/files_trashbin/lib/Trashbin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ public static function ensureFileScannedHook(array $params): void {
* @param string $filename
* @return array
*/
public static function getUidAndFilename($filename): array {
public static function getUidAndFilename(string $filename): array {
$uid = Filesystem::getOwner($filename);
$userManager = \OC::$server->getUserManager();
// if the user with the UID doesn't exists, e.g. because the UID points
Expand Down