Skip to content

[stable27] Fix various file reminders bugs #39887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 3 commits into from
Aug 15, 2023
Merged

[stable27] Fix various file reminders bugs #39887

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efd1e11
fix(files_reminders): Allow non-admin
Pytal Aug 15, 2023
6f879f2
fix(files_reminders): Always respect json output option
Pytal Aug 15, 2023
95688ea
fix(files_reminders): Delete reminders on node deleted
Pytal Aug 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(files_reminders): Always respect json output option 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal @backportbot-nextcloud
Pytal authored and backportbot-nextcloud[bot] committed Aug 15, 2023
commit 6f879f24dbd76676d27c8a3aad327a8f9b49e24b
9 changes: 5 additions & 4 deletions apps/files_reminders/lib/Command/ListCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,6 @@ protected function execute(InputInterface $input, OutputInterface $output): int
}

$reminders = $this->reminderService->getAll($user ?? null);
if (empty($reminders)) {
$io->text('No reminders');
return 0;
}

$outputOption = $input->getOption('output');
switch ($outputOption) {
Expand All @@ -97,6 +93,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
);
return 0;
default:
if (empty($reminders)) {
$io->text('No reminders');
return 0;
}

$io->table(
['User Id', 'File Id', 'Path', 'Due Date', 'Updated At', 'Created At', 'Notified'],
array_map(
Expand Down