Skip to content

[stable27] fix(CardDAV): set owner-principal, displayname properties for SAB #39900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Aug 25, 2023
Merged

[stable27] fix(CardDAV): set owner-principal, displayname properties for SAB #39900

skjnldsv merged 1 commit into from
Aug 25, 2023

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Aug 16, 2023

Manual backport of #39525

@miaulalala miaulalala added bug 3. to review Waiting for reviews labels Aug 16, 2023
@miaulalala miaulalala added this to the Nextcloud 27.1.0 milestone Aug 16, 2023
@miaulalala miaulalala self-assigned this Aug 16, 2023
@miaulalala miaulalala requested a review from JohannesGGE August 16, 2023 08:52
@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 16, 2023

Not sure if this is missing a backport for the authentication fix? cc @JohannesGGE

@JohannesGGE
Copy link
Contributor

JohannesGGE commented Aug 16, 2023

#38397 got in on 18th July (2 days before 27.0.1). So I'm not sure as well, if we have to backport here. 😅
@ChristophWurst

@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 16, 2023

looks like this was after branch off to stable27 then. Backport it is 🙂

@miaulalala
Copy link
Contributor Author

miaulalala commented Aug 16, 2023 •
edited
Loading

@skjnldsv skjnldsv mentioned this pull request Aug 16, 2023
Merged
7 tasks
@miaulalala miaulalala force-pushed the fix/stable27/set-owner-principal-for-SAB branch from 3c3b2f8 to fdce28d Compare August 17, 2023 07:46
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Aug 17, 2023 

There was 1 failure:
295 |  
296 | 1) OCA\DAV\Tests\unit\CardDAV\AddressBookTest::testPropPatchShared
297 | OCA\DAV\CardDAV\CardDavBackend::updateAddressBook(666, Sabre\DAV\PropPatch Object (...)) was not expected to be called.
298 |  
299 | /drone/src/3rdparty/sabre/dav/lib/CardDAV/AddressBook.php:184
300 | /drone/src/apps/dav/lib/CardDAV/AddressBook.php:230
301 | /drone/src/apps/dav/tests/unit/CardDAV/AddressBookTest.php:118

@miaulalala miaulalala force-pushed the fix/stable27/set-owner-principal-for-SAB branch from 88fd1df to b1cbedc Compare August 22, 2023 08:44
@skjnldsv skjnldsv mentioned this pull request Aug 24, 2023
Merged
4 tasks
@skjnldsv skjnldsv force-pushed the fix/stable27/set-owner-principal-for-SAB branch from b1cbedc to 5b5ce26 Compare August 24, 2023 08:06
@miaulalala miaulalala force-pushed the fix/stable27/set-owner-principal-for-SAB branch from 5b5ce26 to 504f396 Compare August 24, 2023 13:07
@skjnldsv skjnldsv merged commit 146cc6a into stable27 Aug 25, 2023
@skjnldsv skjnldsv deleted the fix/stable27/set-owner-principal-for-SAB branch August 25, 2023 06:11
@blizzz blizzz mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Altahrim Altahrim Altahrim approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

@JohannesGGE JohannesGGE Awaiting requested review from JohannesGGE

Assignees

@miaulalala miaulalala

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 27.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@miaulalala @JohannesGGE @skjnldsv @Altahrim