Skip to content

don't bother checking dav acl's in files #39903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icewind1991 merged 1 commit into from
Aug 18, 2023
Merged

don't bother checking dav acl's in files #39903

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
don't bother checking dav acl's in files 
any permissions for files is handled in the filesystem layer anyway

Signed-off-by: Robin Appelman <[email protected]>
  • Loading branch information
@icewind1991
icewind1991 committed Aug 16, 2023
commit 1a9dcc57257911237cac2141ce8484acc128c2ab
5 changes: 5 additions & 0 deletions apps/dav/lib/Connector/Sabre/DavAclPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ public function checkPrivileges($uri, $privileges, $recursion = self::R_PARENT,
}

public function propFind(PropFind $propFind, INode $node) {
if ($node instanceof Node) {
// files don't use dav acls
return;
}

// If the node is neither readable nor writable then fail unless its of
// the standard user-principal
if (!($node instanceof User)) {
Expand Down