Skip to content

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Aug 16, 2023

Summary

In some cases we compared the cache class with a string starting \ and in some others with the ::class which does not have the leading \, so depending on the config value certain bits of functionality would kick in or not.
Now I'm aligning the class names to be without leading \ so we can always compare to ::class

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Aug 16, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Aug 16, 2023
@nickvergessen nickvergessen self-assigned this Aug 16, 2023
@nickvergessen
Copy link
Member Author

/backport to stable27

@nickvergessen
Copy link
Member Author

nickvergessen commented Aug 16, 2023

/backport to stable26

@nickvergessen
Copy link
Member Author

/backport to stable25

@nickvergessen nickvergessen requested review from a team, ArtificialOwl and blizzz and removed request for a team August 16, 2023 14:07
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants