Skip to content

add some recrusive detection/prevention #39990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blizzz merged 2 commits into from
Mar 11, 2024
Merged

add some recrusive detection/prevention #39990

blizzz merged 2 commits into from
Mar 11, 2024

Conversation

@icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Aug 21, 2023

  • Set a maximum depth for the number of nested shared storage setups
  • Once setup, check if the share source comes from the current share

While we try to prevent recursive shares from being created, they are known to sometimes pass through the checks, attempting to use a recursive share leads to hard to debug out of memory issues

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 21, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Aug 21, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, blizzz and nfebe and removed request for a team August 21, 2023 17:48
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv requested a review from a team February 23, 2024 16:15
@skjnldsv skjnldsv force-pushed the recursive-share branch 2 times, most recently from 2e0d5bd to e97578b Compare February 23, 2024 16:18
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 23, 2024
View reviewed changes
@nextcloud nextcloud deleted a comment from github-actions bot Feb 24, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Feb 24, 2024

psalm is valid

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 24, 2024
@icewind1991 icewind1991 force-pushed the recursive-share branch 3 times, most recently from d06e311 to 2ccd21c Compare March 5, 2024 10:23
@blizzz blizzz merged commit b32c0f7 into master Mar 11, 2024
@blizzz blizzz deleted the recursive-share branch March 11, 2024 18:30
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@icewind1991
Copy link
Member Author

icewind1991 commented Mar 19, 2024

/backport to stable28

@icewind1991
Copy link
Member Author

icewind1991 commented Mar 19, 2024

/backport to stable27

@backportbot backportbot bot mentioned this pull request Mar 19, 2024
Merged
2 tasks
@backportbot backportbot bot mentioned this pull request Mar 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfebe nfebe nfebe approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

2. developing Work in progress feature: sharing

Projects

None yet

Milestone

Nextcloud 29

Development

Successfully merging this pull request may close these issues.

6 participants

@icewind1991 @skjnldsv @nfebe @joshtrichards @blizzz