[stable27] feat(dashboard): implement widget item api v2 #39993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API enables the dashboard to render all widgets from the API data alone without having apps to provide their own bundles. This saves a lot of traffic and execution time as a lot less javascript has to be parsed on the frontend. Signed-off-by: Richard Steinmetz <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
enhancement
3. to review
nickvergessen
requested review from
AndyScherzinger,
artonge,
icewind1991 and
susnux
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AndyScherzinger
approved these changes
Aug 22, 2023
Signed-off-by: Joas Schilling <[email protected]>
| foreach ($widgets as $widget) { | ||
| if ($widget instanceof IAPIWidgetV2) { | ||
| $items[$widget->getId()] = $widget | ||
| ->getItemsV2($this->userId, $sinceIds[$widget->getId()] ?? null, $limit) |
Check notice
Code scanning / Psalm
PossiblyNullArgument
AndyScherzinger
approved these changes
Aug 22, 2023
Antreesy
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #39937