Skip to content

Conversation

@miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Aug 23, 2023

Summary

In debug mode, the passwords were logged.

Checklist

@miaulalala miaulalala added this to the Nextcloud 27.1.0 milestone Aug 23, 2023
@miaulalala miaulalala requested review from a team and nickvergessen August 23, 2023 07:36
@miaulalala miaulalala self-assigned this Aug 23, 2023
@miaulalala miaulalala requested review from ArtificialOwl, blizzz and nfebe and removed request for a team August 23, 2023 07:36
@miaulalala
Copy link
Contributor Author

/backport to stable27

@miaulalala
Copy link
Contributor Author

/backport to stable26

@Altahrim
Copy link
Collaborator

LGTM, but didn't test :)

@miaulalala miaulalala force-pushed the fix/remove-pw-from-logging branch from 4e3959e to de75abf Compare August 23, 2023 10:13
@skjnldsv skjnldsv mentioned this pull request Aug 24, 2023
4 tasks
@miaulalala miaulalala force-pushed the fix/remove-pw-from-logging branch from de75abf to 5d5134e Compare August 24, 2023 08:39
@nickvergessen nickvergessen merged commit dce0db8 into master Aug 24, 2023
@nickvergessen nickvergessen deleted the fix/remove-pw-from-logging branch August 24, 2023 09:42
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[Bug]: user_ldap logs user passwords in plain text

6 participants