Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 25, 2023

Manual backport of #39842

Summary

As per xhr.spec.whatwg.org/#the-setrequestheader()-method and infra.spec.whatwg.org/#byte-sequences the header value must be in the range 0x20 (SP) to 0x7E (~) hence we need to encode everything else.

TODO

  • CI

Checklist

@kesselb kesselb changed the base branch from master to stable27 August 25, 2023 15:29
@kesselb kesselb changed the title Backport/27/encode filename trashbin restore [stable27] encode filename trashbin restore Aug 25, 2023
@szaimen szaimen removed request for come-nc and szaimen August 25, 2023 15:30
@kesselb
Copy link
Contributor Author

kesselb commented Aug 25, 2023

Sorry everyone, that was the wrong base 🥳 😆 🙈

@kesselb kesselb added this to the Nextcloud 27.1.0 milestone Aug 25, 2023
@kesselb kesselb added bug 3. to review Waiting for reviews labels Aug 25, 2023
@kesselb kesselb self-assigned this Aug 25, 2023
@skjnldsv skjnldsv merged commit 9577f97 into stable27 Aug 25, 2023
@skjnldsv skjnldsv deleted the backport/27/encode-filename-trashbin-restore branch August 25, 2023 19:18
@blizzz blizzz mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants