Skip to content

Bump @nextcloud/vue to v8 beta 5 + add some visible labels #40084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 6 commits into from
Aug 29, 2023
Merged

Bump @nextcloud/vue to v8 beta 5 + add some visible labels #40084

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b240cc1
chore(deps): Bump @nextcloud/vue to v8 beta 5
Pytal Aug 28, 2023
ffe2951
chore: Migrate to new @nextcloud/vue API
Pytal Aug 28, 2023
e9fd375
enh(a11y): Always visible file rename label
Pytal Aug 28, 2023
7b1f839
enh(a11y): Always visible user management labels
Pytal Aug 28, 2023
5ed9536
chore: compile assets
Pytal Aug 28, 2023
7b93438
chore: Update dav snapshot
Pytal Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enh(a11y): Always visible user management labels 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Aug 29, 2023
commit 7b1f8390c32595efdc1ae7c773f6184a12bb2640
39 changes: 15 additions & 24 deletions apps/settings/src/components/Users/UserRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,19 @@
<td class="row__cell row__cell--displayname"
:data-test="user.id">
<template v-if="idState.editing && user.backendCapabilities.setDisplayName">
<label class="hidden-visually"
:for="'displayName' + uniqueId">
{{ t('settings', 'Edit display name') }}
</label>
<NcTextField :id="'displayName' + uniqueId"
ref="displayNameField"
<NcTextField ref="displayNameField"
data-test="displayNameField"
:show-trailing-button="true"
class="user-row-text-field"
:class="{ 'icon-loading-small': idState.loading.displayName }"
:show-trailing-button="true"
:disabled="idState.loading.displayName || isLoadingField"
:label="t('settings', 'Change display name')"
trailing-button-icon="arrowRight"
:value.sync="idState.editedDisplayName"
autocapitalize="off"
autocomplete="off"
autocorrect="off"
spellcheck="false"
type="text"
@trailing-button-click="updateDisplayName" />
</template>
<template v-else>
Expand All @@ -71,18 +66,13 @@
<td class="row__cell"
:class="{ 'row__cell--obfuscated': hasObfuscated }">
<template v-if="idState.editing && settings.canChangePassword && user.backendCapabilities.setPassword">
<label class="hidden-visually"
:for="'password' + uniqueId">
{{ t('settings', 'Add new password') }}
</label>
<NcTextField :id="'password' + uniqueId"
:show-trailing-button="true"
class="user-row-text-field"
<NcTextField class="user-row-text-field"
:class="{'icon-loading-small': idState.loading.password}"
:show-trailing-button="true"
:disabled="idState.loading.password || isLoadingField"
:minlength="minPasswordLength"
maxlength="469"
:placeholder="t('settings', 'Add new password')"
:label="t('settings', 'Add new password')"
trailing-button-icon="arrowRight"
:value.sync="idState.editedPassword"
autocapitalize="off"
Expand All @@ -100,16 +90,11 @@

<td class="row__cell">
<template v-if="idState.editing">
<label class="hidden-visually"
:for="'mailAddress' + uniqueId">
{{ t('settings', 'Add new email address') }}
</label>
<NcTextField :id="'mailAddress' + uniqueId"
:show-trailing-button="true"
class="user-row-text-field"
<NcTextField class="user-row-text-field"
:class="{'icon-loading-small': idState.loading.mailAddress}"
:show-trailing-button="true"
:disabled="idState.loading.mailAddress || isLoadingField"
:placeholder="t('settings', 'Add new email address')"
:label="t('settings', 'Add new email address')"
trailing-button-icon="arrowRight"
:value.sync="idState.editedMail"
autocapitalize="off"
Expand Down Expand Up @@ -927,6 +912,12 @@ export default {
height: 48px !important;
}

.input-field__input {
&:placeholder-shown:not(:focus) + .input-field__label {
inset-block-start: 16px !important;
}
}

.button-vue--icon-only {
height: 44px !important;
}
Expand Down