Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 29, 2023

Summary

⚠️ One should not disable DNS pinning unless they know what they are doing

A hard requirement for DNS pinning is the ability to resolve DNS records.
If resolving DNS records is not possible, DNS pinning cannot work.

HTTP proxy => DNS names are resolved via proxy (c.f. https://everything.curl.dev/libcurl/proxies#local-or-proxy-name-lookup https://everything.curl.dev/transfers/conn/proxies.html#proxy-types). That explains, why outgoing connections work without the possibility to resolve DNS records locally.

TODO

  • CI

Checklist

@kesselb kesselb self-assigned this Aug 29, 2023
@kesselb kesselb added 3. to review Waiting for reviews bug labels Aug 29, 2023
@kesselb kesselb added this to the Nextcloud 28 milestone Aug 29, 2023
@kesselb
Copy link
Contributor Author

kesselb commented Aug 29, 2023

/backport to stable27

@kesselb
Copy link
Contributor Author

kesselb commented Aug 29, 2023

/backport to stable26

@kesselb kesselb force-pushed the bug/noid/config-dns-pinning branch from a186682 to eab46bd Compare August 29, 2023 16:04
@szaimen

This comment was marked as resolved.

@kesselb

This comment was marked as resolved.

@szaimen

This comment was marked as resolved.

Copy link
Collaborator

@Altahrim Altahrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit sad to come to this, but I don't have a better solution for now ^^

@kesselb kesselb merged commit ec089cf into master Aug 30, 2023
@kesselb kesselb deleted the bug/noid/config-dns-pinning branch August 30, 2023 12:55
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mgallien
Copy link
Contributor

/backport to stable25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants