Refactor OC\Server::getAvatarManager
#40114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
summersab
force-pushed
the
refactor/OC-Server-getAvatarManager
branch
2 times, most recently
from
3e63f6c to
4d9187f
Compare
summersab
force-pushed
the
refactor/OC-Server-getAvatarManager
branch
from
4d9187f to
c582963
Compare
kesselb
approved these changes
Sep 1, 2023
This was referenced Sep 1, 2023
Signed-off-by: Andrew Summers <[email protected]>
summersab
force-pushed
the
refactor/OC-Server-getAvatarManager
branch
from
c582963 to
2258058
Compare
skjnldsv
approved these changes
Sep 1, 2023
kesselb
added
4. to release
Merged
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the deprecated method
OC\Server::getAvatarManagerand replaces it withOC\Server::get(\OCP\IAvatarManager::class)throughout the entire NC codebase (excluding./appsand./3rdparty).Additionally, where necessary, the
\OCP\IAvatarManagerclass is imported via theusedirective.