[stable25] fix(s3): fix handling verify_bucket_exists parameter #40188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid verifying that the bucket exists. However empty(falsy) will always return true, so this condition would not work. Signed-off-by: Thomas Citharel <[email protected]>
backportbot-nextcloud
bot
requested review from
joshtrichards,
juliusknorr,
susnux and
tcitworld
tcitworld
approved these changes
Sep 1, 2023
joshtrichards
added
pending documentation
joshtrichards
approved these changes
Sep 3, 2023
Member
joshtrichards
left a comment
joshtrichards
left a comment
There was a problem hiding this comment.
Bug fix - valid backport LGTM with one caveat that isn't a blocker (because this predates this PR): the NC28/master and NC27 docs have this parameter documented but NC25 docs do not.
Merged
skjnldsv
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #39017