Skip to content

[stable23] enh: skip processing for empty response #40264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
Sep 5, 2023
Merged

[stable23] enh: skip processing for empty response #40264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
enh: skip processing for empty response 
Signed-off-by: Daniel Kesselberg <[email protected]>
  • Loading branch information
@kesselb
kesselb committed Sep 5, 2023
commit 6ddf1b705fca1d9382b771733a9265b15d9fbe12
5 changes: 5 additions & 0 deletions lib/private/Http/Client/DnsPinMiddleware.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
*/
namespace OC\Http\Client;

use OCP\Http\Client\LocalServerException;
use Psr\Http\Message\RequestInterface;

class DnsPinMiddleware {
Expand Down Expand Up @@ -127,6 +128,10 @@ public function addDnsPinning() {

$targetIps = $this->dnsResolve(idn_to_utf8($hostName, IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46), 0);

if (empty($targetIps)) {
throw new LocalServerException('No DNS record found for ' . $hostName);
}

$curlResolves = [];

foreach ($ports as $port) {
Expand Down