Skip to content

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 6, 2023

Summary

We can't use rate limiting outside app framwork controllers. Now we can.

TODO

  • Do

Checklist

*
* @since 28.0.0
*/
interface IRateLimitExceededException extends Throwable {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deliberately exposed an interface not an implementation to avoid a https://en.wikipedia.org/wiki/Fragile_base_class

public function registerUserRequest(string $identifier,
int $userLimit,
int $userPeriod,
IUser $user): void;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IUser $user): void;}
IUser $user): void;
}

@ChristophWurst ChristophWurst requested review from nickvergessen and removed request for nickvergessen September 18, 2023 19:19
@nickvergessen
Copy link
Member

So, CS and we are ready to go

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 19, 2023
@ChristophWurst ChristophWurst force-pushed the feat/appframework/rate-limiter branch from 3a745f3 to 5253bd4 Compare September 19, 2023 14:12
@ChristophWurst ChristophWurst force-pushed the feat/appframework/rate-limiter branch from 5253bd4 to 299bd18 Compare September 19, 2023 14:54
@nickvergessen
Copy link
Member

Autoloader missing an update

@ChristophWurst ChristophWurst force-pushed the feat/appframework/rate-limiter branch from 299bd18 to 1a3a32a Compare September 20, 2023 08:13
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing alias registration

@ChristophWurst ChristophWurst force-pushed the feat/appframework/rate-limiter branch from 1a3a32a to e477bb7 Compare September 20, 2023 18:26
@nickvergessen nickvergessen merged commit 3b6a9cd into master Sep 21, 2023
@nickvergessen nickvergessen deleted the feat/appframework/rate-limiter branch September 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement security

Projects

Development

Successfully merging this pull request may close these issues.

4 participants