fix(caldav): add webroot to objectid for activities #40301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/backport to stable27 |
Contributor
Author
|
/backport to stable26 |
tcitworld
approved these changes
Sep 7, 2023
Member
tcitworld
left a comment
tcitworld
left a comment
There was a problem hiding this comment.
Do you mind adding a check that getWebroot() is called in EventTest.php::testGenerateObjectParameter?
ChristophWurst
approved these changes
Sep 7, 2023
miaulalala
approved these changes
Sep 7, 2023
kesselb
force-pushed
the
bug/noid/webroot-calendar-events-activity
branch
from
a6a68c8 to
19d18ef
Compare
kesselb
added
4. to release
A calendar uri includes the webroot: example.com/cloud/remote.php/dav/calendars/alice/personal/ The calendar app uses base64(calendar uri) as identifier for calendar objects. Without this patch the links from activity app to calendar app don't work for installations in a subdirectory. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/noid/webroot-calendar-events-activity
branch
from
19d18ef to
457f4a5
Compare
ChristophWurst
approved these changes
Sep 13, 2023
ChristophWurst
deleted the
bug/noid/webroot-calendar-events-activity
branch
This was referenced Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A calendar uri includes the webroot: example.com/cloud/remote.php/dav/calendars/alice/personal/
The calendar app uses base64(calendar uri) as identifier for calendar objects.
Without this patch the links from activity app to calendar app don't work for installations in a subdirectory.
TODO
Checklist