Skip to content

Fix Admin AI settings javascript error #40328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Sep 11, 2023
Merged

Fix Admin AI settings javascript error #40328

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84fa05a
Fix Admin AI settings javascript error
marcelklehr Sep 7, 2023
004ef98
Fix eslint error
marcelklehr Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix Admin AI settings javascript error 
make sure all task types we want to display actually exist

Signed-off-by: Marcel Klehr <[email protected]>
  • Loading branch information
@marcelklehr @Pytal
marcelklehr authored and Pytal committed Sep 8, 2023
commit 84fa05abdc146f12450db21247ee9ba0244947c9
5 changes: 4 additions & 1 deletion apps/settings/src/components/AdminAI.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
</NcSettingsSection>
<NcSettingsSection :name="t('settings', 'Text processing')"
:description="t('settings', 'Text processing tasks can be implemented by different apps. Here you can set which app should be used for which task.')">
<template v-for="type in Object.keys(settings['ai.textprocessing_provider_preferences'])">
<template v-for="type in tpTaskTypes">
<div :key="type">
<h3>{{ t('settings', 'Task:') }} {{ getTaskType(type).name }}</h3>
<p>{{ getTaskType(type).description }}</p>
Expand Down Expand Up @@ -110,6 +110,9 @@ export default {
hasTextProcessing() {
return Object.keys(this.settings['ai.textprocessing_provider_preferences']).length > 0 && Array.isArray(this.textProcessingTaskTypes)
},
tpTaskTypes() {
return Object.keys(this.settings['ai.textprocessing_provider_preferences']).filter(type => !!this.getTaskType(type))
},
},
methods: {
moveUp(i) {
Expand Down