[stable27] 40289 fix appearance #40343
Conversation
nfebe
commented
Sep 7, 2023
nfebe
commented
- Resolves: Custom permissions should show permissions in subline #40289
| Before | Currently | Without Icons |
|---|---|---|
 |
 |
 |
nfebe
added
design
|
/compile |
|
@juliushaertl @fenn-cs nice 👍 Can we left-align the content so we are closer to the mockups and v28 as described in #26691 ? |
nfebe
force-pushed
the
40289-stable27-fix-appearance
branch
from
97d1800 to
bbe7e6f
Compare
That was the default, option and I even got a screenshot for it earlier, I just forgot to add it here. The reason, I centered it with the icons, is that, I realized it was centered without them on 27... But yeah done.
cc: @AndyScherzinger |
|
/compile |
nfebe
force-pushed
the
40289-stable27-fix-appearance
branch
2 times, most recently
from
8e054a4 to
f7fc1e5
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
40289-stable27-fix-appearance
branch
from
f7fc1e5 to
500cc77
Compare
| &:first-of-type { | ||
| flex: 10%; | ||
| } | ||
| &:last-of-type { | ||
| flex: 90% | ||
| } |
There was a problem hiding this comment.
Ideally this should be done in the vue components with a proper slot like you did initially :)
There was a problem hiding this comment.
Yeah @skjnldsv, this changes where already made in the component, but where not back-ported (not sure why), so went this route.
There was a problem hiding this comment.
Just design feedback, not blocking:
- The subline alignment of "Create, update, delete, etc." is too far to the left, it should ideally be left-aligned with the "Custom permissions" text as per the mockup. If the subline is too long it should ellipsize after 1 line
- List custom permissions activated in sublime - Align checkboxes in advanced settings Resolves : #40289 Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
40289-stable27-fix-appearance
branch
from
a9cf4ae to
98b54f1
Compare
Signed-off-by: fenn-cs <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
cc: @jancborchardt |
nfebe
force-pushed
the
40289-stable27-fix-appearance
branch
from
98b54f1 to
8113c02
Compare
|
/compile amend / |
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
AndyScherzinger
changed the title
