fix: use faster method to fetch user count #40416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
approved these changes
Sep 14, 2023
countUsers: the actual user count reported by the backend. countSeenUsers: count every user who was logged in once. 1: We should avoid expensive operations (like asking every backend for it's user count) in migrations. 2: The current check is wrong because countUsers returns an array. var_dump([] > 1000) => true ;) Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
fix/noid/check-for-user-count
branch
from
89fd631 to
108916c
Compare
Contributor
Author
|
/backport to stable27 |
ChristophWurst
approved these changes
Sep 14, 2023
miaulalala
approved these changes
Sep 14, 2023
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
countUsers: the actual user count reported by the backend.
countSeenUsers: count every user who was logged in once.
1: We should avoid expensive operations (like asking every backend for its user count) in migrations.
2: The current check is wrong because countUsers returns an array. var_dump([] > 1000) => true ;)
TODO
Checklist