Skip to content

Multiple bug fix in users list #40428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 6 commits into from
Sep 15, 2023
Merged

Multiple bug fix in users list #40428

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd787e8
Do not manipulate userCount when it is equal to 0
artonge Sep 14, 2023
992c03d
Do not preload potential manager list on UserRow mount
artonge Sep 14, 2023
c8fce63
Reset loading state on UserRow mount
artonge Sep 14, 2023
617a9e8
Do not display userCount when it is equal to 0
artonge Sep 14, 2023
50ddc68
fix(ux): Show initial loading state of managers
Pytal Sep 14, 2023
58229ad
chore: compile assets
Pytal Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not preload potential manager list on UserRow mount 
Signed-off-by: Louis Chemineau <[email protected]>
  • Loading branch information
@artonge
artonge committed Sep 14, 2023
commit 992c03d842f962c2900fab715104d310d19dc6bf
3 changes: 1 addition & 2 deletions apps/settings/src/components/Users/UserRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@
:options="idState.possibleManagers"
:placeholder="managerLabel"
class="select-vue"
@open="searchUserManager"
@search="searchUserManager"
@option:selected="updateUserManager"
@input="updateUserManager" />
Expand Down Expand Up @@ -502,8 +503,6 @@ export default {
},

async beforeMount() {
await this.searchUserManager()

if (this.user.manager) {
await this.initManager(this.user.manager)
}
Expand Down