Skip to content

[stable27] Backport consider link shares in removeShare method in SharingTab #40440 #40448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 1 commit into from
Sep 18, 2023
Merged

[stable27] Backport consider link shares in removeShare method in SharingTab #40440 #40448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions apps/files_sharing/src/views/SharingTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,9 +356,16 @@ export default {
* @param {Share} share the share to remove
*/
removeShare(share) {
const index = this.shares.findIndex(item => item.id === share.id)
// eslint-disable-next-line vue/no-mutating-props
this.shares.splice(index, 1)
// Get reference for this.linkShares or this.shares
const shareList
= share.type === this.SHARE_TYPES.SHARE_TYPE_EMAIL
|| share.type === this.SHARE_TYPES.SHARE_TYPE_LINK
? this.linkShares
: this.shares
const index = shareList.findIndex(item => item.id === share.id)
if (index !== -1) {
shareList.splice(index, 1)
}
},
/**
* Await for next tick and render after the list updated
Expand Down
4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.