Skip to content

fix(dav): report status #40474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
Sep 18, 2023
Merged

fix(dav): report status #40474

skjnldsv merged 1 commit into from
Sep 18, 2023

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 18, 2023

Fixed favorites and (incoming) tag view

Context

If a status is defined on the response, it will be used and forced-rendered outside of propstat. Which is invalid according to the RFC and broke in the last webdav update (which is now compliant to the rfc too)

https://github.com/nextcloud/3rdparty/blob/1269091e96a2a550912db37c0d2b29ed5c0aa60f/sabre/dav/lib/DAV/Xml/Element/Response.php#L115-L117

@skjnldsv
fix(dav): report status
63da44b 
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Sep 18, 2023
@skjnldsv skjnldsv requested review from a team and susnux September 18, 2023 09:32
@skjnldsv skjnldsv self-assigned this Sep 18, 2023
@skjnldsv skjnldsv requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a team September 18, 2023 09:32
@skjnldsv skjnldsv mentioned this pull request Sep 18, 2023
Merged
1 task
@skjnldsv skjnldsv merged commit 9ea9743 into master Sep 18, 2023
@skjnldsv skjnldsv deleted the fix/report-dav branch September 18, 2023 12:07
@susnux
Copy link
Contributor

susnux commented Sep 18, 2023

For reference: This one is a workaround for sabre-io/dav#1488

@skjnldsv skjnldsv mentioned this pull request Sep 18, 2023
Merged
@icewind1991
Copy link
Member

icewind1991 commented Sep 18, 2023

Tests meed updating?

There was 1 failure:
--
Failed asserting that null matches expected 200. 
--
/drone/src/apps/dav/tests/unit/Connector/Sabre/FilesReportPluginTest.php:445

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 18, 2023

@icewind1991 #40485

@skjnldsv skjnldsv mentioned this pull request Oct 25, 2023
Merged
@susnux
Copy link
Contributor

susnux commented Feb 21, 2024

/backport to stable27

@backportbot backportbot bot mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991 icewind1991 icewind1991 approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug feature: dav

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @susnux @icewind1991 @artonge