delete filecache entries when the object doesn't exist #40522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| 'message' => 'Could not get object ' . $urn . ' for file ' . $path, | ||
| ]); | ||
| $this->logger->warning("removing filecache entry for object that doesn't seem to exist on the object store. " . json_encode($stat)); | ||
| $this->getCache()->remove((int)$stat['fileid']); |
Check failure
Code scanning / Psalm
InvalidArgument
icewind1991
force-pushed
the
obj-delete-not-found
branch
from
3d27276 to
330fa66
Compare
Merged
icewind1991
force-pushed
the
obj-delete-not-found
branch
from
330fa66 to
daae34e
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Contributor
|
Aligned with @icewind1991 . We should revive this but it's being debated if there can be an improvement made on how to track which files are deleted to give admins the chance to review these. |
icewind1991
force-pushed
the
obj-delete-not-found
branch
from
a9c882d to
cf24bd6
Compare
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
obj-delete-not-found
branch
from
cf24bd6 to
534c4d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the cache and object store get out of sync for any reason we can have items in the cache for an object store with no matching objects. This changes it so the cache item is deleted automatically when such a file is being read.
It logs the full cache item to provide some breadcrumbs if these files ever need to be recovered.
I would like to have a more complete "trashbin" for these items to help with debugging/resolving the cache desync issues but I can't think of anything atm.