[stable27] Consider share type for enforced share expiry dates #40530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
requested review from
AndyScherzinger,
Pytal,
artonge and
juliusknorr
nfebe
force-pushed
the
manual/backport/stable27/40500
branch
from
aff1442 to
8ff7cdd
Compare
AndyScherzinger
approved these changes
Sep 20, 2023
artonge
approved these changes
Sep 20, 2023
nfebe
force-pushed
the
manual/backport/stable27/40500
branch
2 times, most recently
from
e034666 to
cd520a0
Compare
We have three kind of share expiry date enforcements. - `isDefaultExpireDateEnforced` - `isDefaultInternalExpireDateEnforced` - `isDefaultRemoteExpireDateEnforced` Before these commit, `isExpiryDateEnforced` that is used to disable/enable the set expiry date checkbox does not take those into consideration which is problematic as those have different applications. In addition, this commit now uses `isExpiryDateEnforced` to disable/enable the input for expiry date that shows up before the creation of link shares. Here, `hasExpirationDate` is also removed from 'SharingEntryLink` component as it is not used. Signed-off-by: fenn-cs <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
manual/backport/stable27/40500
branch
from
cd520a0 to
cf2b9e8
Compare
Contributor
Author
|
/compile amend / |
Member
|
@fenn-cs I am a irritated. Do we need another compile, or is it actually good? It looks to me like that, with CI being green. |
Contributor
Author
|
@blizzz I don't think we need another compile :) |
blizzz
added
4. to release
Member
|
failing test is unrelated → merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport #40500