Skip to content

fix(dav): expand recurrences when searching #40541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
come-nc merged 1 commit into from
Sep 26, 2023
Merged

fix(dav): expand recurrences when searching #40541

come-nc merged 1 commit into from
Sep 26, 2023

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Sep 20, 2023 •
edited
Loading

Summary

Recurrences are not expanded which leads to the search returning events that are in the past. It just returns the master object instead of recurrences in the requested time range.

Checklist

@st3iny st3iny added this to the Nextcloud 28 milestone Sep 20, 2023
@st3iny st3iny self-assigned this Sep 20, 2023
@st3iny st3iny mentioned this pull request Sep 20, 2023
Merged
1 task
@st3iny st3iny force-pushed the fix/dav/expand-recurrences-in-search branch from 87e2c5b to c25628a Compare September 21, 2023 14:20
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 21, 2023
@st3iny st3iny marked this pull request as ready for review September 21, 2023 14:31
@st3iny
Copy link
Member Author

st3iny commented Sep 21, 2023

/backport to stable27

@st3iny
Copy link
Member Author

st3iny commented Sep 21, 2023

/backport to stable26

@st3iny
Copy link
Member Author

st3iny commented Sep 21, 2023

/backport to stable25

ChristophWurst
ChristophWurst approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@st3iny st3iny force-pushed the fix/dav/expand-recurrences-in-search branch from c25628a to ace0881 Compare September 21, 2023 21:30
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 25, 2023
@st3iny
Copy link
Member Author

st3iny commented Sep 25, 2023

Drone failures are unrelated: integration-checksums-v1 (transient network error)

fatal: unable to access 'https://github.com/nextcloud/server.git/': Could not resolve host: github.com

@come-nc come-nc merged commit 7be31d4 into master Sep 26, 2023
@come-nc come-nc deleted the fix/dav/expand-recurrences-in-search branch September 26, 2023 07:47
This was referenced Sep 26, 2023
Merged
Merged
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@st3iny st3iny mentioned this pull request Sep 26, 2023
Merged
This was referenced Sep 26, 2023
Closed
Closed
Closed
@miaulalala miaulalala mentioned this pull request Feb 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@st3iny st3iny

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: dav

Projects

💌 📅 👥 Groupware team
Archived in project

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Appointment: Blocked calendar slot shows as available

6 participants

@st3iny @ChristophWurst @tcitworld @miaulalala @come-nc