[stable27] Clear progress bar text when hiding it #40572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danxuliu
requested review from
a team,
Pytal,
susnux and
szaimen
and removed request for
a team
Member
Author
|
/backport to stable26 |
Member
Author
|
/backport to stable25 |
danxuliu
force-pushed
the
clear-progress-bar-text-when-hiding-it
branch
from
d1e2154 to
89c4772
Compare
Member
Author
|
Rebased on latest |
szaimen
approved these changes
Sep 25, 2023
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Explanation makes sense but didnt test
susnux
approved these changes
Sep 25, 2023
susnux
added
4. to release
Merged
Merged
When files are uploaded the progress bar text is set accordingly. However, other operations that show the progress bar, like deleting files, do not explicitly set any text. Due to that, when the progress bar was shown again after uploading files the text did not match the operation. To solve that now the text is cleared when the progress bar is hidden (it is not cleared when it is shown as in some cases the text is set already before showing the progress bar). Signed-off-by: Daniel Calviño Sánchez <[email protected]>
blizzz
force-pushed
the
clear-progress-bar-text-when-hiding-it
branch
from
89c4772 to
39bd125
Compare
This was referenced Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When files are uploaded the progress bar text is set accordingly. However, other operations that show the progress bar, like deleting files, do not explicitly set any text. Due to that, when the progress bar was shown again after uploading files the text did not match the operation. To solve that now the text is cleared when the progress bar is hidden (it is not cleared when it is shown as in some cases the text is set already before showing the progress bar).
In Nextcloud 28 this issue no longer happens after moving the Files app to Vue, so the fix is only for Nextcloud 27 and below.
How to test
Result with this pull request
The progress bar shown while deleting the file does not have any text
Result without this pull request
The progress bar shown while deleting the file has
Uploading...or something similar (the last text shown when uploading the file)