Skip to content

feat: Add out-of-office message API #40653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Nov 9, 2023
Merged

feat: Add out-of-office message API #40653

ChristophWurst merged 1 commit into from
Nov 9, 2023

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 27, 2023 •
edited
Loading

Summary

tbd

TODO

  • Emit events
  • Coordinator implementation
  • OCS endpoint(s)
  • Caching layer

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 28 milestone Sep 27, 2023
@ChristophWurst ChristophWurst self-assigned this Sep 27, 2023
@st3iny st3iny assigned st3iny and unassigned ChristophWurst Oct 30, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
st3iny
st3iny reviewed Nov 1, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 1, 2023
View reviewed changes
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
@st3iny st3iny added the pending documentation This pull request needs an associated documentation update label Nov 7, 2023
ChristophWurst
ChristophWurst commented Nov 7, 2023
View reviewed changes
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 8, 2023 •
edited
Loading

  • We will also need an OutOfOfficeClearedEvent next to OutOfOfficeScheduledEvent and OutOfOfficeChangedEvent.

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 8, 2023

Events are emitted. Anything else missing?

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 8, 2023

The events part is definitely done and working. Tested with #41340 :)

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 8, 2023

Let's get this in

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 8, 2023
@ChristophWurst ChristophWurst marked this pull request as ready for review November 8, 2023 15:41
provokateurin
provokateurin approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenAPI looks good

st3iny
st3iny reviewed Nov 8, 2023
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, but now it works. There was a casing issue in ResponseDefinitions.

Thanks for taking care of the cleared event.

Unfortunately, OutOfOfficeStartedEvent and OutOfOfficeEndedEvent are not emitted yet. I have a very crude version locally that has some problems.

I can push it if required. IIRC, we might need it for the autoresponder in Mail.

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Nov 8, 2023

Right. I only looked at the CRUD events, not the time related once.

We can also split the PR into the bits that already work and deliver the rest later

@ChristophWurst @st3iny
feat: Add out-of-office message API
ab1a1d6 
[skipci]

Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny
Copy link
Member

st3iny commented Nov 9, 2023

Unfinished events are gone and we are good now.

ChristophWurst
ChristophWurst commented Nov 9, 2023
View reviewed changes
Copy link
Member Author

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for the latest pushes

miaulalala
miaulalala reviewed Nov 9, 2023
View reviewed changes
@ChristophWurst ChristophWurst merged commit 5183ba2 into master Nov 9, 2023
@ChristophWurst ChristophWurst deleted the feat/ooo-api branch November 9, 2023 17:35
@st3iny st3iny mentioned this pull request Nov 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny left review comments

@miaulalala miaulalala miaulalala approved these changes

@provokateurin provokateurin provokateurin approved these changes

@kesselb kesselb Awaiting requested review from kesselb

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@st3iny st3iny

Labels

3. to review Waiting for reviews feature: users and groups integration pending documentation This pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Out-of-office: Expose data via OCP/OCS APIs

5 participants

@ChristophWurst @st3iny @miaulalala @provokateurin