Skip to content

fix(unifiedsearch): Allow searching for "0" #40675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChristophWurst merged 1 commit into from
Sep 28, 2023
Merged

fix(unifiedsearch): Allow searching for "0" #40675

ChristophWurst merged 1 commit into from
Sep 28, 2023

Conversation

@ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 28, 2023 •
edited
Loading

Summary

empty("0") evaluates to true

Checklist

@ChristophWurst
fix(unifiedsearch): Allow searching for "0"
dbd666e 
empty("0") evaluates to true

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst self-assigned this Sep 28, 2023
@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 28, 2023

/backport to stable27

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 28, 2023

/backport to stable26

@ChristophWurst
Copy link
Member Author

ChristophWurst commented Sep 28, 2023

/backport to stable25

@ChristophWurst ChristophWurst mentioned this pull request Sep 28, 2023
Closed
9 tasks
Antreesy
Antreesy approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦭

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 28, 2023
@ChristophWurst ChristophWurst merged commit f174e4a into master Sep 28, 2023
@ChristophWurst ChristophWurst deleted the fix/unifiedsearch/search-0 branch September 28, 2023 15:18
This was referenced Sep 28, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@come-nc come-nc come-nc approved these changes

@Antreesy Antreesy Antreesy approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@MB-Finski MB-Finski Awaiting requested review from MB-Finski

Assignees

@ChristophWurst ChristophWurst

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: search

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: v25: Typing 0 in the search bar causes errors

5 participants

@ChristophWurst @skjnldsv @come-nc @Antreesy