-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable27] enh(a11y): Add label to share note textbox #40681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Sep 28, 2023
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me but probably ESLint will fail?
artonge
approved these changes
Sep 28, 2023
Pytal
approved these changes
Sep 28, 2023
4a43e7a to
16b569f
Compare
Contributor
Author
|
/compile amend / |
16b569f to
f5e6fc9
Compare
f5e6fc9 to
97db605
Compare
sorbaugh
approved these changes
Oct 2, 2023
97db605 to
1d92ee9
Compare
Merged
1d92ee9 to
7244e92
Compare
Member
|
/compile amend / |
7244e92 to
aecf5c8
Compare
Signed-off-by: Christopher Ng <[email protected]>
aecf5c8 to
4516bb0
Compare
susnux
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
accessibility
feature: sharing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport : #40430