Skip to content

Remove space #40700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Valdnet wants to merge 3 commits into from
Closed

Remove space #40700

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8bbdea1
Remove space
Valdnet Sep 29, 2023
a4e7d1c
chore(assets): Recompile assets
nextcloud-command Sep 29, 2023
c9e53be
Update apps/files_sharing/src/views/SharingDetailsTab.vue
Valdnet Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove space 
Signed-off-by: Valdnet <[email protected]>
  • Loading branch information
@Valdnet
Valdnet authored Sep 29, 2023
commit 8bbdea12d54330861ed798f01256617b6fb515a8
2 changes: 1 addition & 1 deletion apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ export default {

computed: {
title() {
let title = t('files_sharing', 'Share with ')
let title = t('files_sharing', 'Share with')
if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_USER) {
title = title + this.share.shareWithDisplayName
Copy link
Member

@nickvergessen nickvergessen Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per https://docs.nextcloud.com/server/latest/developer_manual/basics/front-end/l10n.html#improving-your-translations this is not good.
It would be better to have a full t() in each of the else-if branches?

} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK) {
Expand Down