Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(OC_Template.php): ensure we throw all errors
In one branch of the try/catch combination, in one specific path no error was thrown at all, thus the user ended up with a 500 error page online but absolutely no error anyway in the logs.

Signed-off-by: Bram <[email protected]>
  • Loading branch information
Psycojoker authored Oct 4, 2023
commit 83b646bc7e03af4c4408eebf84fa8bbb76efa7a7
3 changes: 3 additions & 0 deletions lib/private/legacy/OC_Template.php
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@ public static function printExceptionErrorPage($exception, $statusCode = 503) {
print("The server encountered an internal error and was unable to complete your request.\n");
print("Please contact the server administrator if this error reappears multiple times, please include the technical details below in your report.\n");
print("More details can be found in the server log.\n");

// and then throw it again to log it at least to the web server error log
throw $e;
}
die();
}
Expand Down