Move inline docs to online documentation #40784

szaimen · 2023-10-05T11:06:43Z

This is best reviewed like this: https://github.com/nextcloud/server/pull/40784/files?w=1

needs add shortcuts for linking to root of admin-manual and user-manual documentation#11182

Before	After

apps/settings/templates/help.php

Signed-off-by: Simon L <[email protected]>

JuliaKirschenheuter

Looks good!
Would server/28/go.php?to=admin and server/28/go.php?to=user be fixed in a separate issue, right?

szaimen · 2023-10-06T10:13:09Z

Would server/28/go.php?to=admin and server/28/go.php?to=user be fixed in a separate issue, right?

Yes, implemented in nextcloud/documentation#11182. Only needs to get deployed now

szaimen · 2023-10-06T10:21:39Z

Setting this back to WIP because as discussed with @AndyScherzinger there shall be a config switch to bring back the old iframe version

apps/settings/appinfo/routes.php

apps/settings/css/help.css

apps/settings/lib/Controller/HelpController.php

apps/settings/templates/help.php

core/doc/admin/index.html

core/doc/user/index.html

apps/settings/templates/help.php

Signed-off-by: Simon L <[email protected]>

susnux · 2023-10-06T15:37:55Z

Tested and works, just the button style is a bit weird. It is not consistent with other buttons, is it?

szaimen · 2023-10-06T15:39:27Z

Tested and works, just the button style is a bit weird. It is not consistent with other buttons, is it?

I am not sure. Is there a better css class that I could use or do I need to adjust the styling manually?

susnux · 2023-10-06T15:47:06Z

I am not sure. Is there a better css class that I could use or do I need to adjust the styling manually?

I guess not, seems to be pretty legacy.

As a follow up we should fix the embedded side menu:

Signed-off-by: Simon L <[email protected]>

szaimen · 2023-10-09T14:40:04Z

CI failure unrelated

szaimen added enhancement 2. developing Work in progress accessibility labels Oct 5, 2023

szaimen added this to the Nextcloud 28 milestone Oct 5, 2023

szaimen force-pushed the enh/39414/move-docs branch 2 times, most recently from 0ed44ae to 8f23bb2 Compare October 5, 2023 11:13

szaimen commented Oct 5, 2023

View reviewed changes

apps/settings/templates/help.php Show resolved Hide resolved

szaimen force-pushed the enh/39414/move-docs branch 11 times, most recently from 740056c to 87c62be Compare October 5, 2023 13:17

szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 5, 2023

szaimen marked this pull request as ready for review October 5, 2023 13:21

szaimen requested review from JuliaKirschenheuter, Pytal, ShGKme and susnux October 5, 2023 13:24

Move inline docs to online documentation

6439fdf

Signed-off-by: Simon L <[email protected]>

szaimen force-pushed the enh/39414/move-docs branch from 87c62be to 6439fdf Compare October 5, 2023 13:43

JuliaKirschenheuter reviewed Oct 6, 2023

View reviewed changes

szaimen mentioned this pull request Oct 6, 2023

add shortcuts for linking to root of admin-manual and user-manual nextcloud/documentation#11182

Merged

szaimen marked this pull request as draft October 6, 2023 10:21

szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 6, 2023