fix(user): Log affected user of app token login name mismatch #40795
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
blizzz,
fsamapoor,
kesselb,
max-nextcloud and
tcitworld
Member
Author
|
/backport to stable27 |
Member
Author
|
/backport to stable26 |
blizzz
approved these changes
Oct 6, 2023
tcitworld
approved these changes
Oct 6, 2023
ChristophWurst
deleted the
fix/user/log-app-token-login-name-mismatch-user
branch
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
{ "reqId": "NvLwX40hHD9ntL777fNz", "level": 3, "time": "2023-10-06T06:15:00+00:00", "remoteAddr": "abcd:1234::", "user": "--", "app": "no app in context", "method": "REPORT", "url": "/remote.php/dav/principals/users/usr/", "message": "App token login name does not match", "userAgent": "iOS/17.0.2 (21A351) dataaccessd/1.0", "version": "27.1.2.1", "data": { "tokenLoginName": "usr", "sessionLoginName": "[email protected]" }, "id": "651faa6e0d771" }Which is not easy to process with tools like Sentry because the error can not be associated with the affected user.
Summary
Checklist