Skip to content

Catch Imaginary processing errors #40819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
solracsf merged 2 commits into from
Nov 1, 2023
Merged

Catch Imaginary processing errors #40819

solracsf merged 2 commits into from
Nov 1, 2023

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Oct 8, 2023

Summary

When Imaginary refuses to process images (unsupported, malformed...), resulting in errors 400/406, there is nothing the user/admin can do about it. Log them as info too.

"message": "Imaginary preview generation failed: Client error: `POST http://10.0.0.14:9000/pipeline?operations=%5B%7B%22operation%22%3A%22convert%22%2C%22params%22%3A%7B%22type%22%3A%22png%22%7D%7D%2C%7B%22operation%22%3A%22smartcrop%22%2C%22params%22%3A%7B%22width%22%3A256%2C%22height%22%3A256%2C%22stripmeta%22%3A%22true%22%2C%22type%22%3A%22png%22%2C%22norotation%22%3A%22true%22%2C%22quality%22%3A%2280%22%7D%7D%5D` resulted in a `406 Not Acceptable` response:\n{\"message\":\"Unsupported media type\",\"status\":406}\n",

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Oct 8, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Oct 8, 2023
@szaimen szaimen requested review from a team, artonge, icewind1991, nfebe, sorbaugh and st3iny and removed request for a team October 8, 2023 14:53
@artonge artonge force-pushed the imaginaryGuzzleErrors branch from f8527b6 to 0816bc7 Compare October 9, 2023 08:27
@solracsf solracsf added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 9, 2023
@kesselb

This comment was marked as resolved.

Sign in to view
@solracsf

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@solracsf solracsf force-pushed the imaginaryGuzzleErrors branch from 60ef45a to d1169af Compare November 1, 2023 15:55
@solracsf solracsf enabled auto-merge November 1, 2023 15:55
@solracsf
Copy link
Member Author

solracsf commented Nov 1, 2023

/backport to stable27

@solracsf
Copy link
Member Author

solracsf commented Nov 1, 2023

/backport to stable26

@solracsf solracsf merged commit b46879d into master Nov 1, 2023
@solracsf solracsf deleted the imaginaryGuzzleErrors branch November 1, 2023 16:55
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 1, 2023
Merged
@solracsf
Copy link
Member Author

solracsf commented Nov 2, 2023

/backport to stable26

@solracsf solracsf mentioned this pull request Nov 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe nfebe approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

7 participants

@solracsf @kesselb @st3iny @artonge @nfebe @skjnldsv