[stable27] fix(session): Log when crypto session data is lost #41006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
ChristophWurst,
juliusknorr and
nickvergessen
ChristophWurst
approved these changes
Oct 20, 2023
nickvergessen
approved these changes
Oct 20, 2023
| JSON_THROW_ON_ERROR, | ||
| ); | ||
| } catch (\Exception $e) { | ||
| logger('core')->critical('Could not decrypt or decode encrypted session data', [ |
Member
There was a problem hiding this comment.
Does this log something when your session is brand new? because $this->session->get( returns null => we continue with empty string and then decrypt throws?
Also json_decode('', …) throws which could be returned by decrypt in case everything was empty, didn't dive too deep into it?
Member
There was a problem hiding this comment.
Cherry-picked to this backport, too
ChristophWurst
added
2. developing
Merged
Member
|
moving to 27.1.5 |
Merged
Member
|
moving to 27.1.6 |
Merged
Member
|
Still in draft state. moving to 27.1.7 |
ChristophWurst
added
3. to review
ChristophWurst
force-pushed
the
backport/40879/stable27
branch
from
e2a7b12 to
28a309f
Compare
ChristophWurst
approved these changes
Jan 18, 2024
blizzz
force-pushed
the
backport/40879/stable27
branch
from
28a309f to
789bda6
Compare
susnux
added
4. to release
Signed-off-by: Christoph Wurst <[email protected]>
Signed-off-by: Christoph Wurst <[email protected]>
susnux
force-pushed
the
backport/40879/stable27
branch
from
789bda6 to
bcd7d59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #40879 and #41318