Skip to content

Updated visible 'Twitter' name to 'X' in Personal info #41041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 2 commits into from
Nov 10, 2023
Merged

Updated visible 'Twitter' name to 'X' in Personal info #41041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4871f59
Updated visible 'Twitter' name to 'X' in Personal info
gcald Oct 22, 2023
a047686
Updated visible 'Twitter' name to 'X' in Personal info
gcald Oct 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updated visible 'Twitter' name to 'X' in Personal info 
Signed-off-by: George Calderon <[email protected]>
  • Loading branch information
@gcald @AndyScherzinger
gcald authored and AndyScherzinger committed Nov 10, 2023
commit 4871f59c35842591912c8bbb34e8bd3b2ed34932
2 changes: 1 addition & 1 deletion apps/settings/src/components/PersonalInfo/TwitterSection.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

<template>
<AccountPropertySection v-bind.sync="twitter"
:placeholder="t('settings', 'Your Twitter handle')" />
:placeholder="t('settings', 'Your X handle')" />
Copy link
Contributor

@szaimen szaimen Oct 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe?

Suggested change
:placeholder="t('settings', 'Your X handle')" />
:placeholder="t('settings', 'Your X
(formerly Twitter) handle')" />

Copy link
Contributor Author

@gcald gcald Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've updated the PR.

</template>

<script>
Expand Down
2 changes: 1 addition & 1 deletion apps/settings/src/constants/AccountPropertyConstants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export const ACCOUNT_PROPERTY_READABLE_ENUM = Object.freeze({
PHONE: t('settings', 'Phone number'),
PROFILE_ENABLED: t('settings', 'Profile'),
ROLE: t('settings', 'Role'),
TWITTER: t('settings', 'Twitter'),
TWITTER: t('settings', 'X (Formerly Twitter)'),
Copy link
Contributor

@szaimen szaimen Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TWITTER: t('settings', 'X (Formerly Twitter)'),
TWITTER: t('settings', 'X (formerly Twitter)'),

Copy link
Contributor Author

@gcald gcald Oct 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I've updated the PR.

FEDIVERSE: t('settings', 'Fediverse (e.g. Mastodon)'),
WEBSITE: t('settings', 'Website'),
})
Expand Down