fix(files_external): on case insensitive system, block case change #41053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altahrim
requested review from
ArtificialOwl and
nfebe
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
When a file/directory is renamed to the same name with only case change, the rename fail. We block this kind of rename. The user will have to rename to another name first. Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
bug/smb/in-place-case-rename
branch
from
3b90d78 to
a45e12a
Compare
come-nc
reviewed
Oct 23, 2023
come-nc
approved these changes
Oct 23, 2023
Collaborator
Author
|
/backport to stable27 |
Collaborator
Author
|
/backport to stable26 |
juliusknorr
approved these changes
Oct 30, 2023
Collaborator
Author
|
CI failure seems unrelated |
This was referenced Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an option to declare a SMB share case-insensitive.
When a file/directory is renamed to the same name with only case change, the rename fail. We block this kind of rename.
The user will have to rename to another name first.