optimize UserMountCache::registerStorage #41057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
Altahrim,
blizzz and
nfebe
and removed request for
a team
Merged
Merged
icewind1991
force-pushed
the
registermounts-opt
branch
from
8e93901 to
f6f6d74
Compare
Merged
blizzz
requested changes
Nov 13, 2023
Member
blizzz
left a comment
blizzz
left a comment
There was a problem hiding this comment.
Missing required annotation, otherwise 👍
Merged
Altahrim
force-pushed
the
registermounts-opt
branch
from
f6f6d74 to
51868d7
Compare
blizzz
approved these changes
Nov 16, 2023
juliusknorr
approved these changes
Nov 16, 2023
juliusknorr
requested changes
Nov 16, 2023
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Ah wait CI shows some issue:
PHP Fatal error: Nesting level too deep - recursive dependency? in /home/runner/work/server/server/lib/private/Files/Config/UserMountCache.php on line 130
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Altahrim
force-pushed
the
registermounts-opt
branch
from
631b839 to
feb8ff6
Compare
juliusknorr
reviewed
Nov 16, 2023
Altahrim
force-pushed
the
registermounts-opt
branch
from
feb8ff6 to
7a2d994
Compare
Signed-off-by: Robin Appelman <[email protected]> Signed-off-by: Benjamin Gaussorgues <[email protected]>
Altahrim
force-pushed
the
registermounts-opt
branch
from
7a2d994 to
b942850
Compare
juliusknorr
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the logic a bit and use less intermediate arrays