Skip to content

fix(theming): Correctly expose user and admin theming #41059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 1 commit into from
Nov 6, 2023
Merged

fix(theming): Correctly expose user and admin theming #41059

provokateurin merged 1 commit into from
Nov 6, 2023

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 23, 2023

Supersedes #40877

Summary

The capabilities were mixing the admin theme and the user theme.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Oct 23, 2023
@provokateurin provokateurin added this to the Nextcloud 28 milestone Oct 23, 2023
@provokateurin provokateurin mentioned this pull request Oct 23, 2023
Closed
4 tasks
@provokateurin provokateurin force-pushed the fix/theming/capabilities branch from 623fad9 to bc37cb4 Compare October 29, 2023 16:56
skjnldsv
skjnldsv reviewed Oct 31, 2023
View reviewed changes
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
@provokateurin provokateurin force-pushed the fix/theming/capabilities branch from bc37cb4 to 6920148 Compare November 2, 2023 10:40
@szaimen szaimen removed their request for review November 2, 2023 15:29
@provokateurin provokateurin force-pushed the fix/theming/capabilities branch from 6920148 to e69e201 Compare November 3, 2023 08:36
@skjnldsv skjnldsv requested review from a team, icewind1991 and sorbaugh and removed request for a team November 3, 2023 08:59
@provokateurin provokateurin merged commit 738faf4 into master Nov 6, 2023
@provokateurin provokateurin deleted the fix/theming/capabilities branch November 6, 2023 08:20
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin @juliusknorr @skjnldsv