Skip to content

Conversation

@nickvergessen
Copy link
Member

@ChristophWurst there are more places in apps/dav/ that use functions from Safe, but also catch it's exceptions. Maybe you can clear that code with your team

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Oct 23, 2023
@nickvergessen nickvergessen self-assigned this Oct 23, 2023
@ChristophWurst
Copy link
Member

@ChristophWurst there are more places in apps/dav/ that use functions from Safe, but also catch it's exceptions. Maybe you can clear that code with your team

Code was added with #30963, #31673 and #35121. I can't find any other usage.

@nickvergessen
Copy link
Member Author

@Pytal @susnux can you as authors then take care of removing it from those code places? That'd be cool and helpful!

@nickvergessen nickvergessen merged commit 7a55ea7 into master Oct 24, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/dont-use-indirect-dependency branch October 24, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants