Improve setup checks naming and improve database version check #41083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if ($databasePlatform instanceof MySQLPlatform) { | ||
| $result = $this->connection->prepare("SHOW VARIABLES LIKE 'version';"); | ||
| $result->execute(); | ||
| $row = $result->fetch(); |
Check notice
Code scanning / Psalm
DeprecatedMethod
| } elseif ($databasePlatform instanceof PostgreSQLPlatform) { | ||
| $result = $this->connection->prepare('SHOW server_version;'); | ||
| $result->execute(); | ||
| $row = $result->fetch(); |
Check notice
Code scanning / Psalm
DeprecatedMethod
8 tasks
come-nc
added
3. to review
8 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve setup checks naming so that output of the checks feel more natural.
Also fix and improves database version checking.
Using #41081 , before:
current state:
Checklist