Skip to content

Conversation

@icewind1991
Copy link
Member

try to figure out specificly what's wrong with the config and try to give suggestions how to fix it instead of just throwing generic exceptions.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 28, 2017
@icewind1991 icewind1991 added this to the Nextcloud 12.0 milestone Mar 28, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @nickvergessen and @MorrisJobke to be potential reviewers.

@oparoz
Copy link
Member

oparoz commented Mar 28, 2017

Great! 👍

@codecov-io
Copy link

Codecov Report

Merging #4112 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #4112      +/-   ##
===========================================
- Coverage     54.23%   54.2%   -0.03%     
- Complexity    21278   21294      +16     
===========================================
  Files          1310    1310              
  Lines         81213   81253      +40     
  Branches       1285    1285              
===========================================
+ Hits          44043   44045       +2     
- Misses        37170   37208      +38
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/ObjectStore/Swift.php 0% <0%> (ø) 33 <9> (+16) ⬆️
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 73.64% <0%> (+0.24%) 133% <0%> (ø) ⬇️
apps/comments/lib/EventHandler.php 87.5% <0%> (+8.33%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f88a578...489c472. Read the comment docs.

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 28, 2017
@icewind1991 icewind1991 merged commit e26f138 into master Mar 28, 2017
@icewind1991 icewind1991 deleted the swift-config branch March 28, 2017 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants