Skip to content

fix: don't pass invalid streams to Imaginary #41120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
szaimen merged 1 commit into from
Oct 26, 2023
Merged

fix: don't pass invalid streams to Imaginary #41120

szaimen merged 1 commit into from
Oct 26, 2023

Conversation

@solracsf
Copy link
Member

@solracsf solracsf commented Oct 25, 2023 •
edited
Loading

Summary

Don't pass invalid streams to Imaginary to avoid "empty" errors.

https://github.com/h2non/imaginary/blob/7efb66c243056e5b3b65215e101be7915983e364/error.go#L19

GuzzleHttp\Exception\ClientException: Client error: `POST http://10.0.0.14:9000/pipeline?operations=%5B%7B%22operation%22%3A%22autorotate%22%7D%2C%7B%22operation%22%3A%22fit%22%2C%22params%22%3A%7B%22width%22%3A1024%2C%22height%22%3A1024%2C%22stripmeta%22%3A%22true%22%2C%22type%22%3A%22png%22%2C%22norotation%22%3A%22true%22%2C%22quality%22%3A%2280%22%7D%7D%5D` resulted in a `400 Bad Request` response: {"message":"Empty or unreadable image","status":400}

Checklist

@solracsf solracsf added this to the Nextcloud 28 milestone Oct 25, 2023
@solracsf solracsf closed this Oct 25, 2023
@solracsf solracsf reopened this Oct 25, 2023
@solracsf solracsf force-pushed the imaginaryInvalidStream branch from 5889a0d to 91f80a7 Compare October 25, 2023 18:07
@solracsf
Don't pass invalid streams to Imaginary
974e86e 
Signed-off-by: Git'Fellow <[email protected]>

Update Imaginary.php

Signed-off-by: Git'Fellow <[email protected]>

Update Imaginary.php

Signed-off-by: Git'Fellow <[email protected]>
@solracsf solracsf force-pushed the imaginaryInvalidStream branch from 8c261b3 to 974e86e Compare October 25, 2023 19:59
szaimen
szaimen approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it makes sense but did not test

@szaimen szaimen merged commit 4c8232f into master Oct 26, 2023
@szaimen szaimen deleted the imaginaryInvalidStream branch October 26, 2023 09:59
@solracsf
Copy link
Member Author

solracsf commented Oct 29, 2023 •
edited
Loading

This will also fix things like:

"fclose(): supplied resource is not a valid stream resource in file '/lib/private/Preview/Imaginary.php' line 181"

@solracsf
Copy link
Member Author

solracsf commented Oct 29, 2023

/backport to stable27

@solracsf
Copy link
Member Author

solracsf commented Oct 29, 2023

/backport to stable26

@solracsf solracsf changed the title Don't pass invalid streams to Imaginary fix: don't pass invalid streams to Imaginary Oct 29, 2023
This was referenced Oct 29, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artonge artonge artonge approved these changes

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@st3iny st3iny Awaiting requested review from st3iny

Assignees

No one assigned

Labels

3. to review Waiting for reviews feature: previews and thumbnails

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@solracsf @artonge @szaimen