Skip to content

"Share with" wording fix in new share panel #41155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jerome-Herbinet wants to merge 3 commits into from
Closed

"Share with" wording fix in new share panel #41155

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4702f0b
Update SharingDetailsTab.vue
Jerome-Herbinet Oct 27, 2023
b9bc4df
npm run build
Jerome-Herbinet Oct 27, 2023
7dee136
fixup!: Ensure that the string can be translated independed of senten…
susnux Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup!: Ensure that the string can be translated independed of senten… 
…ce order of language

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed Nov 2, 2023
commit 7dee136c6340e1f4379997a3465cbfea32341087
25 changes: 16 additions & 9 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,24 +292,31 @@ export default {

computed: {
title() {
let title = t('files_sharing', 'Shared with') + ' ';
// TRANSLATORS: "shared with XX"
let shareWith = t('files_sharing', 'user');
if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_USER) {
title = title + this.share.shareWithDisplayName
shareWith = this.share.shareWithDisplayName
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK) {
title = t('files_sharing', 'Share link')
// TRANSLATORS: "shared with XX"
shareWith = t('files_sharing', 'Share link')
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_GROUP) {
title += ` (${t('files_sharing', 'group')})`
// TRANSLATORS: "shared with XX"
shareWith = t('files_sharing', 'group')
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_ROOM) {
title += ` (${t('files_sharing', 'conversation')})`
// TRANSLATORS: "shared with XX"
shareWith = t('files_sharing', 'conversation')
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_REMOTE) {
title += ` (${t('files_sharing', 'remote')})`
// TRANSLATORS: "shared with XX"
shareWith = t('files_sharing', 'remote')
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_REMOTE_GROUP) {
title += ` (${t('files_sharing', 'remote group')})`
// TRANSLATORS: "shared with XX"
shareWith = t('files_sharing', 'remote group')
} else if (this.share.type === this.SHARE_TYPES.SHARE_TYPE_GUEST) {
title += ` (${t('files_sharing', 'guest')})`
// TRANSLATORS: "shared with XX"
shareWith = t('files_sharing', 'guest')
}

return title
return t('files_sharing', 'Shared with {sharedWith}', { shareWith })
},
/**
* Can the sharee edit the shared file ?
Expand Down