Skip to content

enh(TextProcessing): Add two new provider interfaces #41271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 16 commits into from
Nov 13, 2023
Merged

enh(TextProcessing): Add two new provider interfaces #41271

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
181f819
enh(TextProcessing): Add IProvider2
marcelklehr Nov 3, 2023
d11b9cb
fix(TextProcessing/Manager): Throw TaskFailureException upon failure
marcelklehr Nov 6, 2023
26a659d
fix(TextProcessing/Manager): add canuseProvider check in getPreferred…
marcelklehr Nov 6, 2023
1476a72
fix(TextProcessing/ migration): add check whether new column exists a…
marcelklehr Nov 6, 2023
b01e0c3
enh: update openapi.json
marcelklehr Nov 6, 2023
fecf642
fix: psalm issues and coding style
marcelklehr Nov 6, 2023
17e7b6c
fix: split IProvider2 into two more verbose interfaces
marcelklehr Nov 7, 2023
b8862bd
fix coding style
marcelklehr Nov 7, 2023
8c0c426
Merge branch 'master' into enh/text-processing-iprovider2
marcelklehr Nov 8, 2023
12c558f
Update lib/private/TextProcessing/Manager.php
marcelklehr Nov 8, 2023
6fbf430
Update lib/private/TextProcessing/Manager.php
marcelklehr Nov 8, 2023
a29ed70
Update lib/public/TextProcessing/IProviderWithUserId.php
marcelklehr Nov 8, 2023
b45007f
Merge branch 'master' into enh/text-processing-iprovider2
marcelklehr Nov 9, 2023
5704281
fix: Update autoloaders
marcelklehr Nov 9, 2023
017f136
fix: Don't try to access undefined array key
marcelklehr Nov 9, 2023
2031fe1
fix: Make sure array starts at 0 after array filter
marcelklehr Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/private/TextProcessing/Manager.php 
Co-authored-by: Julien Veyssier <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
  • Loading branch information
@marcelklehr @julien-nc
marcelklehr and julien-nc authored Nov 8, 2023
commit 6fbf430fe30a90d900397a28a3357d0e1fc7ffb5
2 changes: 1 addition & 1 deletion lib/private/TextProcessing/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ public function scheduleTask(OCPTask $task): void {
throw new PreConditionNotMetException('No LanguageModel provider is installed that can handle this task');
}
$task->setStatus(OCPTask::STATUS_SCHEDULED);
[$provider, ] = $this->getPreferredProviders($task);
[$provider,] = $this->getPreferredProviders($task);
if ($provider instanceof IProviderWithExpectedRuntime) {
$completionExpectedAt = new \DateTime('now');
$completionExpectedAt->add(new \DateInterval('PT'.$provider->getExpectedRuntime().'S'));
Expand Down