Skip to content

fix(dav): Add ID / label to timezone picker in availablility settings #41285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
susnux merged 4 commits into from
Nov 6, 2023
Merged

fix(dav): Add ID / label to timezone picker in availablility settings #41285

susnux merged 4 commits into from
Nov 6, 2023

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Nov 4, 2023

Summary

No visual changes but the "strong" element is now a label for the timezone picker.

Also needed to update @nextcloud/vue

Checklist

@susnux susnux mentioned this pull request Nov 4, 2023
Closed
@susnux susnux merged commit 4154ba3 into master Nov 6, 2023
@susnux susnux deleted the fix/id-timezone branch November 6, 2023 15:14
@blizzz blizzz mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@szaimen szaimen Awaiting requested review from szaimen

Assignees

No one assigned

Labels

3. to review Waiting for reviews accessibility bug feature: settings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@susnux @AndyScherzinger @ChristophWurst @JuliaKirschenheuter @ShGKme