Skip to content

fix(log): Log exception class when message is empty #41406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickvergessen merged 1 commit into from
Nov 13, 2023
Merged

fix(log): Log exception class when message is empty #41406

nickvergessen merged 1 commit into from
Nov 13, 2023

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Nov 13, 2023

  • Resolves:
  • Before is first line
  • After is last line

grafik

Checklist

@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Nov 13, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Nov 13, 2023
@nickvergessen nickvergessen self-assigned this Nov 13, 2023
@nickvergessen nickvergessen requested review from ArtificialOwl, nfebe and sorbaugh and removed request for a team November 13, 2023 08:50
tcitworld
tcitworld approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add an "Exception thrown:" prefix for context?

@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
ChristophWurst
ChristophWurst approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also find out where an empty log message is logged?

@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 13, 2023

Can we also find out where an empty log message is logged?

The error from production was in logged via this:

server/index.php

Line 81 in bb2c2bb

\OC::$server->get(LoggerInterface::class)->error($ex->getMessage(), [

@nickvergessen nickvergessen force-pushed the bugfix/noid/log-exception-class-when-message-is-empty branch from 78915b9 to a5684ea Compare November 13, 2023 11:45
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 13, 2023

Added the prefix

@nickvergessen nickvergessen merged commit 073ec6d into master Nov 13, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/log-exception-class-when-message-is-empty branch November 13, 2023 13:28
@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 13, 2023

/backport to stable27

@nickvergessen
Copy link
Member Author

nickvergessen commented Nov 13, 2023

/backport to stable26

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 13, 2023
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @ChristophWurst @tcitworld