Fix tests for setupchecks

Signed-off-by: Côme Chilliet <[email protected]>

apps/settings/lib/SetupChecks/BruteForceThrottler.php

@@ -62,12 +62,12 @@ public function run(): SetupResult {
 			}
 		} elseif ($this->throttler->showBruteforceWarning($address)) {
 			return SetupResult::error(
-				$this->l10n->t('Your remote address was identified as "%s" and is bruteforce throttled at the moment slowing down the performance of various requests. If the remote address is not your address this can be an indication that a proxy is not configured correctly.', $address),
+				$this->l10n->t('Your remote address was identified as "%s" and is bruteforce throttled at the moment slowing down the performance of various requests. If the remote address is not your address this can be an indication that a proxy is not configured correctly.', [$address]),
 				$this->urlGenerator->linkToDocs('admin-reverse-proxy')
 			);
 		} else {
 			return SetupResult::success(
-				$this->l10n->t('Your remote address "%s" is not bruteforce throttled.', $address)
+				$this->l10n->t('Your remote address "%s" is not bruteforce throttled.', [$address])
 			);
 		}
 	}

apps/settings/lib/SetupChecks/ForwardedForHeaders.php

@@ -79,7 +79,7 @@ public function run(): SetupResult {
 		if (\in_array($remoteAddress, $trustedProxies, true) && ($remoteAddress !== '127.0.0.1')) {
 			if ($remoteAddress !== $detectedRemoteAddress) {
 				/* Remote address was successfuly fixed */
-				return SetupResult::success($this->l10n->t('Your IP address was resolved as %s', $detectedRemoteAddress));
+				return SetupResult::success($this->l10n->t('Your IP address was resolved as %s', [$detectedRemoteAddress]));
 			} else {
 				return SetupResult::warning(
 					$this->l10n->t('The reverse proxy header configuration is incorrect, or you are accessing Nextcloud from a trusted proxy. If not, this is a security issue and can allow an attacker to spoof their IP address as visible to the Nextcloud.'),

apps/settings/tests/SetupChecks/ForwardedForHeadersTest.php

@@ -133,7 +133,7 @@ public function testForwardedHostPresentButTrustedProxiesEmpty(): void {
 			->willReturn('1.1.1.1');
 
 		$this->assertEquals(
-			SetupResult::WARNING,
+			SetupResult::ERROR,
 			$this->check->run()->getSeverity()
 		);
 	}